openblas: apply patch to prevent SIGILL on aarch64 #117004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Mar 20, 2021
|
/rebase staging |
The applied patch contains the changes from this PR: OpenMathLib/OpenBLAS#3060 This patch prevents gcc from reordering instructions in a way that can cause crashes with SIGILL on aarch64. This issue crashes python when importing numpy on aarch64: numpy/numpy#18131
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
github-actions
bot
force-pushed
the
openblas-apply-patch-to-prevent-sigill-on-aarch64
branch
from
7d472d8
to
0226220
Compare
|
Rebased, please reopen the pull request to restart CI |
There was a problem hiding this comment.
Just curious: why does the output contain an empty bin directory?
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 117004 run on x86_64-linux 1
1 package built:
- openblas
I don't know. It's there on both |
mschwaig
added a commit
to mschwaig/tensorflow-hello-world-nix-flake
that referenced
this pull request
Apr 16, 2021
The updated version of nixpkgs includes NixOS/nixpkgs#117004 so that TensorFlow should now work with the openblas version from nixpkgs on aarch64 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The applied patch contains the changes from this PR:
OpenMathLib/OpenBLAS#3060
This patch prevents gcc from reordering instructions in a way
that can cause crashes with SIGILL on aarch64.
This issue crashes python when importing numpy on aarch64:
numpy/numpy#18131
Motivation for this change
Without this
python -c "import numpy"crashes withSIGILLonaarch64.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)