Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide (darwin): fix or enable darwin build for many packages (7) #117011

Merged
merged 11 commits into from Mar 20, 2021
Merged

treewide (darwin): fix or enable darwin build for many packages (7) #117011

merged 11 commits into from Mar 20, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Mar 20, 2021 •
edited

Motivation for this change

See #114976 for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 20, 2021
@siraben siraben force-pushed the darwin-mass-fix-buildInputs=0 branch from 731ed81 to 32b366f Compare March 20, 2021 05:41
@siraben
Copy link
Member Author

siraben commented Mar 20, 2021

Result of nixpkgs-review pr 117011 run on x86_64-darwin 1

11 packages built:
  • asc-key-to-qr-code-gif
  • bash-supergenpass
  • gt5
  • pdfcrack
  • philter
  • pixiecore
  • pixiewps
  • redir
  • rshijack
  • shc
  • surfraw

@SuperSandro2000 SuperSandro2000 merged commit 4c817c7 into NixOS:master Mar 20, 2021
@siraben siraben deleted the darwin-mass-fix-buildInputs=0 branch March 21, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @SuperSandro2000