lmdb: 0.9.25 -> 0.9.28

[vcunat]

https://github.com/LMDB/lmdb/blob/LMDB_0.9.28/libraries/liblmdb/CHANGES

---

I think it's pretty safe (and seems to work for me), but let me open a PR for a few days.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 117016 at fb542cd run on aarch64-linux 1

62 packages marked as broken and skipped:

• gnome3.gnome-books
• gnome3.gnome-documents
• libsForQt512.baloo
• libsForQt512.baloo-widgets
• libsForQt512.discover
• libsForQt512.dolphin
• libsForQt512.dolphin-plugins
• libsForQt512.dragon
• libsForQt512.elisa
• libsForQt512.gwenview
• ...

3 packages failed to build (new failures):

• gnome3.sushi
• pantheon.appcenter
• setzer

46 packages skipped due to time constraints:

• caffe
• denemo
• dero
• gerbil
• gerbil-unstable
• glom
• kdev-php
• kdev-python
• kdevelop-unwrapped
• knot-dns
• ...

41 packages built successfully:

• appstream
• bookworm
• evince
(gnome3.evince)
• feeds
• gawkextlib.lmdb
• grab-site
• haskellPackages.lmdb
• haskellPackages.lmdb-high-level
• haskellPackages.lmdb-simple
• libsForQt5.appstream-qt
(libsForQt515.appstream-qt ,plasma5Packages.appstream-qt)
• libsForQt5.baloo
(libsForQt515.baloo ,plasma5Packages.baloo)
• libsForQt5.baloo-widgets
(libsForQt515.baloo-widgets ,plasma5Packages.baloo-widgets)
• libsForQt5.dragon
(libsForQt515.dragon ,plasma5Packages.dragon)
• libsForQt5.kde-cli-tools
(libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
• libsForQt5.khotkeys
(libsForQt515.khotkeys ,plasma5Packages.khotkeys)
• libsForQt5.kmenuedit
(libsForQt515.kmenuedit ,plasma5Packages.kmenuedit)
• libsForQt5.krohnkite
(libsForQt515.krohnkite ,plasma5Packages.krohnkite)
• libsForQt5.kwin-dynamic-workspaces
(libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
• libsForQt5.kwin-tiling
(libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
• libsForQt5.parachute
(libsForQt515.parachute ,plasma5Packages.parachute)
• libsForQt5.plasma-browser-integration
(libsForQt515.plasma-browser-integration ,plasma5Packages.plasma-browser-integration)
• libsForQt5.plasma-disks
(libsForQt515.plasma-disks ,plasma5Packages.plasma-disks)
• libsForQt5.plasma-workspace
(libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
• libsForQt5.systemsettings
(libsForQt515.systemsettings ,plasma5Packages.systemsettings)
• libsForQt512.appstream-qt
• libsForQt514.appstream-qt
• libsForQt514.baloo
• libsForQt514.baloo-widgets
• libsForQt514.dragon
• lmdb
• metadata-cleaner
• meteo
• pantheon.elementary-calculator
• pantheon.elementary-camera
• pantheon.elementary-code
• pantheon.elementary-greeter
• pantheon.elementary-terminal
• pantheon.wingpanel-applications-menu
• pantheon.wingpanel-with-indicators
• pentobi
• snippetpixie

2 suggestions:

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/libraries/lmdb/default.nix:15:15:

     |
  15 |   patches = [ ./hardcoded-compiler.patch ];
     |               ^
  

• warning: missing-phase-hooks

  checkPhase should probably contain runHook preCheck and runHook postCheck.

  Near pkgs/development/libraries/lmdb/default.nix:28:3:

     |
  28 |   checkPhase = "make test";
     |   ^
  

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 117016 run on x86_64-linux 1

52 packages marked as broken and skipped:

• gnome3.gnome-books
• gnome3.gnome-documents
• libsForQt512.baloo
• libsForQt512.baloo-widgets
• libsForQt512.discover
• libsForQt512.dolphin
• libsForQt512.dolphin-plugins
• libsForQt512.dragon
• libsForQt512.elisa
• libsForQt512.gwenview
• libsForQt512.kde-cli-tools
• libsForQt512.kdeplasma-addons
• libsForQt512.khotkeys
• libsForQt512.kinfocenter
• libsForQt512.kmenuedit
• libsForQt512.krohnkite
• libsForQt512.kwin-dynamic-workspaces
• libsForQt512.kwin-tiling
• libsForQt512.parachute
• libsForQt512.plasma-browser-integration
• libsForQt512.plasma-desktop
• libsForQt512.plasma-disks
• libsForQt512.plasma-workspace
• libsForQt512.powerdevil
• libsForQt512.systemsettings
• libsForQt514.discover
• libsForQt514.elisa
• libsForQt514.kde-cli-tools
• libsForQt514.kdeplasma-addons
• libsForQt514.khotkeys
• libsForQt514.kinfocenter
• libsForQt514.kmenuedit
• libsForQt514.krohnkite
• libsForQt514.kwin-dynamic-workspaces
• libsForQt514.kwin-tiling
• libsForQt514.parachute
• libsForQt514.plasma-browser-integration
• libsForQt514.plasma-desktop
• libsForQt514.plasma-disks
• libsForQt514.plasma-workspace
• libsForQt514.powerdevil
• libsForQt514.systemsettings
• python38Packages.arviz
• python38Packages.dm-sonnet
• python38Packages.graph_nets
• python38Packages.optuna
• python38Packages.pymc3
• python38Packages.rl-coach
• python39Packages.dm-sonnet
• python39Packages.graph_nets
• python39Packages.optuna
• python39Packages.rl-coach

4 packages failed to build and already failed to build on hydra master:

• dero: log was empty
• libsForQt5.discover: log was empty
• masari: log was empty
• pantheon.appcenter: log was empty

2 packages failed to build and are new build failures:

• (libsForQt515.discover: log was empty
• ,plasma5Packages.discover): log was empty

81 packages built:

• appstream
• bookworm
• caffe
• denemo
• evince (gnome3.evince)
• feeds
• gawk-with-extensions
• gawkextlib.lmdb
• gerbil
• gerbil-unstable
• glom
• gnome3.sushi
• grab-site
• haskellPackages.lmdb
• haskellPackages.lmdb-high-level
• haskellPackages.lmdb-simple
• kdev-php
• kdev-python
• kdevelop
• kdevelop-unwrapped
• knot-dns
• knot-resolver
• libmodsecurity
• libsForQt5.appstream-qt (libsForQt515.appstream-qt ,plasma5Packages.appstream-qt)
• libsForQt5.baloo (libsForQt515.baloo ,plasma5Packages.baloo)
• libsForQt5.baloo-widgets (libsForQt515.baloo-widgets ,plasma5Packages.baloo-widgets)
• libsForQt5.dolphin (libsForQt515.dolphin ,plasma5Packages.dolphin)
• libsForQt5.dolphin-plugins (libsForQt515.dolphin-plugins ,plasma5Packages.dolphin-plugins)
• libsForQt5.dragon (libsForQt515.dragon ,plasma5Packages.dragon)
• libsForQt5.elisa (libsForQt515.elisa ,plasma5Packages.elisa)
• libsForQt5.gwenview (libsForQt515.gwenview ,plasma5Packages.gwenview)
• libsForQt5.kde-cli-tools (libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
• libsForQt5.kdeplasma-addons (libsForQt515.kdeplasma-addons ,plasma5Packages.kdeplasma-addons)
• libsForQt5.khotkeys (libsForQt515.khotkeys ,plasma5Packages.khotkeys)
• libsForQt5.kinfocenter (libsForQt515.kinfocenter ,plasma5Packages.kinfocenter)
• libsForQt5.kmenuedit (libsForQt515.kmenuedit ,plasma5Packages.kmenuedit)
• libsForQt5.krohnkite (libsForQt515.krohnkite ,plasma5Packages.krohnkite)
• libsForQt5.kwin-dynamic-workspaces (libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
• libsForQt5.kwin-tiling (libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
• libsForQt5.parachute (libsForQt515.parachute ,plasma5Packages.parachute)
• libsForQt5.plasma-browser-integration (libsForQt515.plasma-browser-integration ,plasma5Packages.plasma-browser-integration)
• libsForQt5.plasma-desktop (libsForQt515.plasma-desktop ,plasma5Packages.plasma-desktop)
• libsForQt5.plasma-disks (libsForQt515.plasma-disks ,plasma5Packages.plasma-disks)
• libsForQt5.plasma-workspace (libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
• libsForQt5.powerdevil (libsForQt515.powerdevil ,plasma5Packages.powerdevil)
• libsForQt5.systemsettings (libsForQt515.systemsettings ,plasma5Packages.systemsettings)
• libsForQt512.appstream-qt
• libsForQt514.appstream-qt
• libsForQt514.baloo
• libsForQt514.baloo-widgets
• libsForQt514.dolphin
• libsForQt514.dolphin-plugins
• libsForQt514.dragon
• libsForQt514.gwenview
• lmdb
• lmdbxx
• metadata-cleaner
• meteo
• murmur
• neomutt
• nheko
• pantheon.elementary-calculator
• pantheon.elementary-camera
• pantheon.elementary-code
• pantheon.elementary-greeter
• pantheon.elementary-photos
• pantheon.elementary-terminal
• pantheon.wingpanel-applications-menu
• pantheon.wingpanel-with-indicators
• pentobi
• peruse
• python38Packages.caffe
• python39Packages.caffe
• setzer
• snippetpixie
• sumokoin
• tengine
• tilix
• wacomtablet
• zeroc-ice
• zeroc-ice-cpp11

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

appstream:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/appstream/default.nix:42:3:

   |
42 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md