Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poke: fix darwin build #117025

Merged
merged 1 commit into from Mar 20, 2021
Merged

poke: fix darwin build #117025

merged 1 commit into from Mar 20, 2021

Conversation

midchildan
Copy link
Member

Motivation for this change

This removes nbd support on Darwin because it's incompatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan
poke: fix darwin build
1b5e28c 
This removes nbd support on Darwin because it's incompatible.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 20, 2021
@SuperSandro2000 SuperSandro2000 merged commit 5576460 into NixOS:master Mar 20, 2021
@midchildan midchildan deleted the fix/poke/darwin-build branch March 20, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau Awaiting requested review from kira-bruneau

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@midchildan @SuperSandro2000