Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mupdf: fix CVE-2021-3407 #117040

Merged
merged 2 commits into from Mar 21, 2021
Merged

mupdf: fix CVE-2021-3407 #117040

merged 2 commits into from Mar 21, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #116896

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 20, 2021

Result of nixpkgs-review pr 117040 at 206e3f4 run on x86_64-linux 1

10 packages built successfully:
5 suggestions:
  • error: no-flags-spaces

    makeFlags cannot contain spaces, please use makeFlagsArray in Bash.

    Near pkgs/applications/misc/mupdf/default.nix:55:3:

       |
    55 |   makeFlags = [ "prefix=$(out) USE_SYSTEM_LIBS=yes" ];
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:26:5:

       |
    26 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:31:5:

       |
    31 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:36:5:

       |
    36 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:41:5:

       |
    41 |     (fetchpatch {
       |     ^
    

Result of nixpkgs-review pr 117040 at 206e3f4 run on aarch64-linux 1

10 packages built successfully:
5 suggestions:
  • error: no-flags-spaces

    makeFlags cannot contain spaces, please use makeFlagsArray in Bash.

    Near pkgs/applications/misc/mupdf/default.nix:55:3:

       |
    55 |   makeFlags = [ "prefix=$(out) USE_SYSTEM_LIBS=yes" ];
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:26:5:

       |
    26 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:31:5:

       |
    31 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:36:5:

       |
    36 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/misc/mupdf/default.nix:41:5:

       |
    41 |     (fetchpatch {
       |     ^
    

@risicle
Copy link
Contributor

risicle commented Mar 21, 2021

Looks right to me, nixpkgs-review happy for me, linux x86_64, macos 10.14

@SuperSandro2000 SuperSandro2000 merged commit 17ef805 into NixOS:master Mar 21, 2021
@dotlambda dotlambda deleted the CVE-2021-3407 branch March 22, 2021 08:54
@dotlambda
Copy link
Member Author

backport: #117199

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 100: mupdf-1.18.0: 1 advisory [5.5]
5 participants