Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/factorio: update admin setting #117044

Merged
merged 1 commit into from May 15, 2021
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 20, 2021

Motivation for this change

Friends noticed they couldn't do any admin actions, seems admin settings have been moved into a separate file.

cc @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

also, running a server with this applied, and it's working on 1.27

@jonringer
Copy link
Contributor Author

server still works fine

@jonringer jonringer merged commit 5a6540c into NixOS:master May 15, 2021
@jonringer jonringer deleted the factorio-admin branch May 15, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants