Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sphinx: Add missing "packaging" dependency #117050

Closed
wants to merge 1 commit into from
Closed

python3Packages.sphinx: Add missing "packaging" dependency #117050

wants to merge 1 commit into from

Conversation

matthewmazzanti
Copy link
Contributor

Motivation for this change

Upstream sphinx has a dependency on "packaging", which is not duplicated
in the nix expression, causing build failures on staging.

Things done

Add dependency to fix this build

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewmazzanti
python3Packages.sphinx: Add missing "packaging" dependency
0372496 
Upstream sphinx has a dependency on "packaging", which is not duplicated
in the nix expression, causing build failusres on staging. Add
dependency to fix this build
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 20, 2021 •
edited

Good catch but this was already fixed with 83fa5d2 and on the current staging tip sphinx builds fine.

Thanks for your PR anyway :)

@matthewmazzanti
Copy link
Contributor Author

Man you guys are fast here.

@matthewmazzanti matthewmazzanti deleted the fix-sphinx branch March 20, 2021 19:06
@SuperSandro2000
Copy link
Member

Man you guys are fast here.

sphinx is probably used somewhere core (maybe the manual?) so the breakage was noticed really fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewmazzanti @SuperSandro2000