New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnutls: Fix failing patch for Aarch32 #117051
Conversation
A patch for tests that fail on arm has been upstreamed, and is no longer needed. I have gated this behind a lib.versionOlder to allow the build.
Why add the versionOlder and not just drop the patch? |
In the same file theres a "versionAtLeast" here, so I wanted to keep with the flow and maintain the ability to change versions if needed. If it would be more appropriate to just drop the patch, let me know. |
We only tend to do that for packages with a common infrastructure that multiple versions are built from. Apparently this used to be the case for gnutls until 33e7d72/#58611. IMHO having conditions which only ever evaluate to the same result is an antipattern and should be avoided, but if it is to be expected that a |
Well I can remove the patch entirely, thats no problem. Do you want me to remove the other version dependent reference as well, or leave it in? |
Removed the patch. |
Can we target master here? |
Tried to change the base directly and it looked nasty. Let me do a cherry pick and open a new PR. |
New pr here: #117279 |
Motivation for this change
A patch for tests that fail on arm has been upstreamed, and is no longer
needed.
Things done
I have gated this behind a lib.versionOlder to allow the build.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)