New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/keycloak: use db username in db init scripts #117072
Conversation
/cc @talyz |
Hi! The problem with this is that changing |
ping @grahamc for informational purposes. |
9ca49a8
to
2ade022
Compare
I'm unsure if this module should handle changing the database username after deployment. The reason I wanted to change the database username is that I know people having a specific schema for database users and 'keycloak' doesn't fit into this schema. But it's not that important to support this. |
Maybe it would be fine to add a note that tells users they have to manually adjust the state to make sure the user has the permissions when changing the value assigned to this option after the first deployment? |
For me that would be a good option |
2ade022
to
d9e18f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation for this change
I would like to use a different database username, but want to use the automatic provisioning scripts provided by the NixOS Keycloak module
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)