Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: fix build on darwin #117076

Merged
merged 1 commit into from Mar 21, 2021
Merged

mpd: fix build on darwin #117076

merged 1 commit into from Mar 21, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 20, 2021

Motivation for this change

Fixes #117061
cc: @smancill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Mar 20, 2021
SuperSandro2000
SuperSandro2000 reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine on darwin

@smancill
Copy link
Contributor

Thanks, that was fast.

It builds on my mac now.

@SuperSandro2000 SuperSandro2000 merged commit 2ae8d4b into NixOS:master Mar 21, 2021
@marsam marsam deleted the fix-mpd-darwin branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpd 0.22.6 doesn't build in Darwin
3 participants
@marsam @smancill @SuperSandro2000