Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypari2, cysignals: updates #117123

Merged
merged 4 commits into from Mar 24, 2021
Merged

cypari2, cysignals: updates #117123

merged 4 commits into from Mar 24, 2021

Conversation

collares
Copy link
Member

@collares collares commented Mar 21, 2021

Motivation for this change

Some Sage-related package updates that didn't make it into #114881. For future PRs, the following still needs to be done (after Sage 9.3, probably):

Closes #103810.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 21, 2021

Result of nixpkgs-review pr 117123 at 305874ad run on aarch64-linux 1

8 packages built successfully:
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/python-modules/cypari2/default.nix:62:5:

       |
    62 |     license = licenses.gpl2;
       |     ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/python-modules/cysignals/default.nix:2:3:

      |
    2 | , fetchpatch
      |   ^
    

Result of nixpkgs-review pr 117123 at 305874ad run on x86_64-linux 1

2 packages skipped due to time constraints:
  • sage
  • sageWithDoc
8 packages built successfully:
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/python-modules/cypari2/default.nix:62:5:

       |
    62 |     license = licenses.gpl2;
       |     ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/python-modules/cysignals/default.nix:2:3:

      |
    2 | , fetchpatch
      |   ^
    

Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for continued work on updating dependencies! I will look into this.

Regarding unclear-gpl, cypari2 is gpl2Plus (source).

@collares
Copy link
Member Author

Thank you @omasanori! Changed cypari2 to reflect that.

@ofborg ofborg bot requested a review from omasanori March 21, 2021 15:55
@collares
Copy link
Member Author

collares commented Mar 21, 2021

Tests are failing on aarch64, but they were already failing before (see the testrun on #117017 for example). Any ideas?

@ofborg build sage

@timokau
Copy link
Member

timokau commented Mar 22, 2021

If the failure is unrelated I think the fix is out of scope for this PR. You could mark sage as broken on that platform for now to reduce the time hydra and others waste trying to build it and increase the "signal to noise ratio" of the CI.

Is this PR still a work in progress?

@collares
Copy link
Member Author

@timokau I was doing some more investigation on the aarch64 failures (every test that uses Jmol hangs, apparently), but as you said this is out of scope for the current PR. So this PR is ready now.

@collares
Copy link
Member Author

As for marking sage as broken on aarch64, I am debugging the jmol hangs at #117465. If I can't find a cause, I'll mark it as broken there.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

@timokau timokau merged commit 82e1bfa into NixOS:master Mar 24, 2021
@collares
Copy link
Member Author

Thanks for the review and for merging!

@collares collares deleted the cypari-update branch March 25, 2021 12:56
@collares collares mentioned this pull request Apr 25, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants