Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.git: 3.3.2 -> 3.3.3 #117135

Merged
merged 1 commit into from Mar 25, 2021
Merged

ocamlPackages.git: 3.3.2 -> 3.3.3 #117135

merged 1 commit into from Mar 25, 2021

Conversation

sternenseemann
Copy link
Member

Fixes a stack-overflow for very large trees.

https://github.com/mirage/ocaml-git/releases/tag/3.3.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@ofborg build ocamlPackages.irmin-unix

@vbgl vbgl merged commit 6aac9b5 into NixOS:master Mar 25, 2021
@sternenseemann sternenseemann deleted the git-3.3.3 branch March 25, 2021 19:12
@sternenseemann sternenseemann restored the git-3.3.3 branch July 24, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl