bearssl: init at 0.6 & s6-networking bearssl backend #117136
Conversation
Profpatsch
force-pushed
the
bearssl-init
branch
from
d83a839
to
1f1c0a6
Compare
| inherit sha256; | ||
| }; | ||
|
|
||
| outputs = [ "bin" "lib" "dev" "out" ]; |
There was a problem hiding this comment.
Wouldn't lib be a more appropriate default output?
There was a problem hiding this comment.
bin is always expected to come first, the code that needs lib usually knows to default to it.
| install -Dm644 build/libbearssl.so $lib/lib/libbearssl.so | ||
| install -Dm644 build/libbearssl.a $lib/lib/libbearssl.a | ||
| install -Dm644 -t $dev/include inc/*.h | ||
| touch $out |
There was a problem hiding this comment.
Isn't $out a directory propagating lib and bin?
There was a problem hiding this comment.
It didn’t work without the touch …
|
Result of 2 packages built successfully:
1 suggestion:
Result of 2 packages built successfully:
1 suggestion:
|
18·27 <Profpatsch> skarnet: would you recommend putting bearssl as the default backend for s6-networking? 18·27 <Profpatsch> uh, bearssl isn’t even packaged 18·27 <Profpatsch> yak shave 18·28 <Profpatsch> skarnet: The current backend uses libressl 18·29 <@skarnet> well at least CAFILE works 18·29 <@skarnet> but yes, I would recommend putting bearssl as the default backend
Profpatsch
force-pushed
the
bearssl-init
branch
from
1f1c0a6
to
1918f20
Compare
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)