pythonPackages: fix nix-shell development environments #117157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 919 packages marked as broken and skipped:
1 package failed to build:21919 packages skipped due to time constraints:
235 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 825 packages marked as broken and skipped:
1 package failed to build:24172 packages skipped due to time constraints:
204 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
|
/rebase staging |
A change in setuptools v49.0.0 broke the development mode of Python packages inside nix-shell. This workaround fixes it. Closes NixOS#108525.
github-actions
bot
force-pushed
the
fix-nix-shell-python
branch
from
bb560f8
to
53737f7
Compare
|
Rebased, please reopen the pull request to restart CI |
FRidh
reviewed
Mar 23, 2021
| # a sitecustomize.py file is a workaround for making nix-shell | ||
| # environments work again. | ||
| # See https://github.com/pypa/setuptools/issues/2612 | ||
| cat >"$tmp_path/@pythonSitePackages@/sitecustomize.py" <<EOF |
There was a problem hiding this comment.
Our interpreter comes with a sitecustomize.py. I suppose this one could take precedence and so it works. This may stop working if we put more logic in the main one though.
I think we could use the existing sitecustomize.py for this by just exporting
NIX_PYTHONPATH="$tmp_path/@pythonSitePackages@"
|
Thank you for looking into this. I've pushed 7a65bb7 to staging. Please test this. |
|
I tested the staging branch and the problem looks fixed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in setuptools v49.0.0 broke the development mode of Python
packages inside nix-shell. This workaround fixes it.
Closes #108525.
Note that this change will require a rebuild of all Python packages. I only tested the change using the example described in the issue (using the sampleproject package). I'm not sure if this change will introduce a regression, so if possible hydra should check that all Python packages work ok before merging this.
Motivation for this change
Fix #108525.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)