Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python38Packages.jupyterlab: 3.0.11 -> 3.0.12 #117166

Merged
merged 1 commit into from Mar 22, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python38Packages.jupyterlab is: "Jupyter lab environment notebook server extension."

meta.homepage for python38Packages.jupyterlab is: "https://jupyter.org/"

meta.changelog for python38Packages.jupyterlab is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python38Packages.jupyterlab
python39Packages.jupyterlab
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/rl6wnrqiqdqr9zss6c8hc0xxizxl67lg-python3.8-jupyterlab-3.0.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python38Packages.jupyterlab https://github.com/r-ryantm/nixpkgs/archive/70d52487b65b0d2bb5bdc4c845c73f91fd3f3bf4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/rl6wnrqiqdqr9zss6c8hc0xxizxl67lg-python3.8-jupyterlab-3.0.12
ls -la /nix/store/rl6wnrqiqdqr9zss6c8hc0xxizxl67lg-python3.8-jupyterlab-3.0.12/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • python38Packages.jupyterlab
  • python39Packages.jupyterlab

Maintainer pings

cc @zimbatm @costrouc for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 22, 2021

Result of nixpkgs-review pr 117166 at 70d5248 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.jupyterlab
  • python39Packages.jupyterlab
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/jupyterlab/default.nix:31:0:

       |
    31 |     description = "Jupyter lab environment notebook server extension.";
       | ^
    

Result of nixpkgs-review pr 117166 at 70d5248 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.jupyterlab
  • python39Packages.jupyterlab
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/jupyterlab/default.nix:31:0:

       |
    31 |     description = "Jupyter lab environment notebook server extension.";
       | ^
    

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 117166 run on x86_64-linux 1

2 packages built:
  • python38Packages.jupyterlab
  • python39Packages.jupyterlab

@jonringer jonringer merged commit ad99325 into NixOS:master Mar 22, 2021
@r-ryantm r-ryantm deleted the auto-update/python3.8-jupyterlab branch March 22, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants