swaycwd: init at 0.0.1

[cab404]

Motivation for this change

Added swaycwd — xcwd for sway.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 117176 at 6deee9bc run on aarch64-linux 1

1 package built successfully:

• swaycwd

3 suggestions:

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/tools/wayland/swaycwd/default.nix:24:5:

     |
  24 |     buildPhase = ''
     |     ^
  

• warning: missing-phase-hooks

  configurePhase should probably contain runHook preConfigure and runHook postConfigure.

  Near pkgs/tools/wayland/swaycwd/default.nix:15:5:

     |
  15 |     configurePhase = ''
     |     ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/wayland/swaycwd/default.nix:29:5:

     |
  29 |     installPhase = ''
     |     ^
  

---

Result of nixpkgs-review pr 117176 at 6deee9bc run on x86_64-linux 1

1 package built successfully:

• swaycwd

3 suggestions:

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/tools/wayland/swaycwd/default.nix:24:5:

     |
  24 |     buildPhase = ''
     |     ^
  

• warning: missing-phase-hooks

  configurePhase should probably contain runHook preConfigure and runHook postConfigure.

  Near pkgs/tools/wayland/swaycwd/default.nix:15:5:

     |
  15 |     configurePhase = ''
     |     ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/wayland/swaycwd/default.nix:29:5:

     |
  29 |     installPhase = ''
     |     ^
  

[fogti]

The bot already mentioned this. Hooks should be called in all defined phases here (e.g. configurePhase, buildPhase, installPhase)

[fogti]

nitpick: indention of the *Phase blocks is currently mostly 4 spaces, but I think it might be better if the indention was consistently 2 spaces.

[fogti]

You should apply the suggestions of SuperSandro and then squash all the commits in this PR.

[cab404]

Thanks for the help!

[cab404]

@r-rmcgibbo

[SuperSandro2000]

Your repo is no longer available.

[cab404]

Your repo is no longer available.

@SuperSandro2000 Are you sure that's wasn't a temporary GitLab outage? Just checked, everything seems fine.

[SuperSandro2000]

Your repo is no longer available.

@SuperSandro2000 Are you sure that's wasn't a temporary GitLab outage? Just checked, everything seems fine.

I searched for it on GitHub... 🤦🏼