Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nco: 4.9.7 -> 4.9.8 #117221

Closed
wants to merge 1 commit into from
Closed

nco: 4.9.7 -> 4.9.8 #117221

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/nco/nco/releases.

meta.description for nco is: "NetCDF Operator toolkit"

meta.homepage for nco is: "http://nco.sourceforge.net/"

meta.changelog for nco is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
nco
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/q0dyrmqv3w90j2cgan431qph1v6j4rp9-nco-4.9.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nco https://github.com/r-ryantm/nixpkgs/archive/4d529b8cf99d9da266a3e8e23f7c3cf193888bcc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/q0dyrmqv3w90j2cgan431qph1v6j4rp9-nco-4.9.8
ls -la /nix/store/q0dyrmqv3w90j2cgan431qph1v6j4rp9-nco-4.9.8/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • nco

Maintainer pings

cc @bzizou for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 22, 2021

Result of nixpkgs-review pr 117221 at 4d529b8 run on x86_64-linux 1

1 package built successfully:
  • nco
2 suggestions:
  • warning: build-tools-in-build-inputs

    antlr is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/nco/default.nix:8:3:

      |
    8 |   buildInputs = [ netcdf netcdfcxx4 gsl udunits antlr curl coreutils ];
      |   ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/development/libraries/nco/default.nix:26:5:

       |
    26 |     license = lib.licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 117221 at 4d529b8 run on aarch64-linux 1

1 package failed to build:
2 suggestions:
  • warning: build-tools-in-build-inputs

    antlr is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/nco/default.nix:8:3:

      |
    8 |   buildInputs = [ netcdf netcdfcxx4 gsl udunits antlr curl coreutils ];
      |   ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/development/libraries/nco/default.nix:26:5:

       |
    26 |     license = lib.licenses.gpl3;
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Copy link
Contributor

@bzizou bzizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created another PR with the fixes: #117341

@ryantm ryantm closed this Mar 23, 2021
@r-ryantm r-ryantm deleted the auto-update/nco branch March 23, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants