Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gambit: fix compiler paths #117240

Merged
merged 1 commit into from Mar 26, 2021
Merged

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

Prior to the recent merge, the full paths were specified here, so gambit would get the full paths and not need to propagate the compiler inputs. This restores that behavior while keeping the architecture prefixes.

This allows packages (transitively) depending on gambit to work again. Specifically, I have a number of local gerbil packages that stopped building, and this fixes them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fare @7c6f434c

Prior to the recent merge, the full paths were specified here, so
gambit would get the full paths and not need to propagate the compiler
inputs.
@fare
Copy link
Contributor

fare commented Mar 22, 2021

Note that this is already fixed in #114449 but that patch is somehow stalled.

@7c6f434c 7c6f434c merged commit 36f2c10 into NixOS:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants