Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kconf: init at 1.10.1 #117265

Merged
merged 1 commit into from Mar 30, 2021
Merged

kconf: init at 1.10.1 #117265

merged 1 commit into from Mar 30, 2021

Conversation

thmzlt
Copy link
Contributor

@thmzlt thmzlt commented Mar 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 22, 2021 19:00
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/487

SuperSandro2000
SuperSandro2000 reviewed Mar 22, 2021
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -30461,4 +30461,6 @@ in
lc3tools = callPackage ../development/tools/lc3tools {};

zktree = callPackage ../applications/misc/zktree {};

kconf = callPackage ../applications/networking/cluster/kconf { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort this entry into a category and there alphabetically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find a pattern, but there are networking/cluster packages spread across the entire file. Can you point to where this entry should go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a headline like ```### NETWORK`` and yeah we need to programmatically sort this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a ### NETWORK header, but I moved it near some other Kubernetes-related tools. Is this better?

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 30, 2021

@SuperSandro2000, would you mind taking another look at this? Thanks.

@SuperSandro2000 SuperSandro2000 merged commit ac570d2 into NixOS:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thmzlt @nixos-discourse @SuperSandro2000