Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apacheHttpdPackages: drop mod_evasive, use recurseIntoAttrs for apacheHttpdPackages #117269

Merged
merged 2 commits into from Mar 25, 2021
Merged

apacheHttpdPackages: drop mod_evasive, use recurseIntoAttrs for apacheHttpdPackages #117269

merged 2 commits into from Mar 25, 2021

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 22, 2021 •
edited

Motivation for this change
  • version bump for mod_perl (see apacheHttpdPackages.mod_perl: 2.0.10 -> 2.0.11 #117420)
  • drop mod_evasive... looks this was missed a few years back when we dropped support for apacheHttpd-2.2
  • include apacheHttpdPackages in the binary cache, though I'm not sure about this one given the mod_evasive attribute throws now ... anyone know about that? 🤷‍♂️
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 22, 2021 •
edited

Result of nixpkgs-review pr 117269 at a63ce767 run on aarch64-linux 1

1 package skipped due to time constraints:
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
19 packages built successfully:
  • apacheHttpdPackages.apacheHttpd (apacheHttpdPackages_2_4.apacheHttpd)
  • apacheHttpdPackages.mod_auth_mellon (apacheHttpdPackages_2_4.mod_auth_mellon)
  • apacheHttpdPackages.mod_ca (apacheHttpdPackages_2_4.mod_ca)
  • apacheHttpdPackages.mod_crl (apacheHttpdPackages_2_4.mod_crl)
  • apacheHttpdPackages.mod_csr (apacheHttpdPackages_2_4.mod_csr)
  • apacheHttpdPackages.mod_dnssd (apacheHttpdPackages_2_4.mod_dnssd)
  • apacheHttpdPackages.mod_fastcgi (apacheHttpdPackages_2_4.mod_fastcgi)
  • apacheHttpdPackages.mod_ocsp (apacheHttpdPackages_2_4.mod_ocsp)
  • apacheHttpdPackages.mod_pkcs12 (apacheHttpdPackages_2_4.mod_pkcs12)
  • apacheHttpdPackages.mod_python (apacheHttpdPackages_2_4.mod_python)
  • apacheHttpdPackages.mod_scep (apacheHttpdPackages_2_4.mod_scep)
  • apacheHttpdPackages.mod_spkac (apacheHttpdPackages_2_4.mod_spkac)
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)
  • apacheHttpdPackages.mod_wsgi (apacheHttpdPackages.mod_wsgi2 ,apacheHttpdPackages_2_4.mod_wsgi ,apacheHttpdPackages_2_4.mod_wsgi2)
  • apacheHttpdPackages.mod_wsgi3 (apacheHttpdPackages_2_4.mod_wsgi3)
  • apacheHttpdPackages.php (apacheHttpdPackages_2_4.php)
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • perl530Packages.libapreq2
  • perl532Packages.libapreq2

Result of nixpkgs-review pr 117269 at a63ce767 run on x86_64-linux 1

21 packages built successfully:
  • apacheHttpdPackages.apacheHttpd (apacheHttpdPackages_2_4.apacheHttpd)
  • apacheHttpdPackages.mod_auth_mellon (apacheHttpdPackages_2_4.mod_auth_mellon)
  • apacheHttpdPackages.mod_ca (apacheHttpdPackages_2_4.mod_ca)
  • apacheHttpdPackages.mod_crl (apacheHttpdPackages_2_4.mod_crl)
  • apacheHttpdPackages.mod_csr (apacheHttpdPackages_2_4.mod_csr)
  • apacheHttpdPackages.mod_dnssd (apacheHttpdPackages_2_4.mod_dnssd)
  • apacheHttpdPackages.mod_fastcgi (apacheHttpdPackages_2_4.mod_fastcgi)
  • apacheHttpdPackages.mod_ocsp (apacheHttpdPackages_2_4.mod_ocsp)
  • apacheHttpdPackages.mod_perl (apacheHttpdPackages_2_4.mod_perl)
  • apacheHttpdPackages.mod_pkcs12 (apacheHttpdPackages_2_4.mod_pkcs12)
  • apacheHttpdPackages.mod_python (apacheHttpdPackages_2_4.mod_python)
  • apacheHttpdPackages.mod_scep (apacheHttpdPackages_2_4.mod_scep)
  • apacheHttpdPackages.mod_spkac (apacheHttpdPackages_2_4.mod_spkac)
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)
  • apacheHttpdPackages.mod_wsgi (apacheHttpdPackages.mod_wsgi2 ,apacheHttpdPackages_2_4.mod_wsgi ,apacheHttpdPackages_2_4.mod_wsgi2)
  • apacheHttpdPackages.mod_wsgi3 (apacheHttpdPackages_2_4.mod_wsgi3)
  • apacheHttpdPackages.php (apacheHttpdPackages_2_4.php)
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • perl530Packages.libapreq2
  • perl532Packages.libapreq2
4 suggestions:
  • warning: license-missing

    Package is missing a license.

    Near pkgs/servers/http/apache-modules/mod_perl/default.nix:12:3:

       |
12 |   buildInputs = [ apacheHttpd perl ];
   |   ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/servers/http/apache-modules/mod_perl/default.nix:12:3:

       |
12 |   buildInputs = [ apacheHttpd perl ];
   |   ^
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/servers/http/apache-modules/mod_perl/default.nix:13:3:

       |
13 |   buildPhase = ''
   |   ^
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/http/apache-modules/mod_perl/default.nix:18:3:

       |
18 |   installPhase = ''
   |   ^

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 117269 run on x86_64-darwin 1

4 packages failed to build and already failed to build on hydra master:
  • apacheHttpdPackages.mod_python: log was empty
  • (apacheHttpdPackages_2_4.mod_python): log was empty
  • apacheHttpdPackages.php: log was empty
  • (apacheHttpdPackages_2_4.php): log was empty
12 packages built:
  • apacheHttpdPackages.apacheHttpd (apacheHttpdPackages_2_4.apacheHttpd)
  • apacheHttpdPackages.mod_ca (apacheHttpdPackages_2_4.mod_ca)
  • apacheHttpdPackages.mod_crl (apacheHttpdPackages_2_4.mod_crl)
  • apacheHttpdPackages.mod_csr (apacheHttpdPackages_2_4.mod_csr)
  • apacheHttpdPackages.mod_ocsp (apacheHttpdPackages_2_4.mod_ocsp)
  • apacheHttpdPackages.mod_pkcs12 (apacheHttpdPackages_2_4.mod_pkcs12)
  • apacheHttpdPackages.mod_scep (apacheHttpdPackages_2_4.mod_scep)
  • apacheHttpdPackages.mod_spkac (apacheHttpdPackages_2_4.mod_spkac)
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)
  • apacheHttpdPackages.subversion (apacheHttpdPackages_2_4.subversion)
  • perl530Packages.libapreq2
  • perl532Packages.libapreq2

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

apacheHttpdPackages.apacheHttpd:

warning: EvalError
Cannot evaluate attribute ‘apacheHttpdPackages.apacheHttpd’ in ‘/nix/store/37m29yhgyh3jdsvyz0a13x4hvhmb435y-nixpkgs’.

@risicle
Copy link
Contributor

risicle commented Mar 22, 2021

nixpkgs-review happy, linux x86_64.

Shocked to find we don't have a nixos test covering mod_perl

@aanderse aanderse changed the title apacheHttpdPackages: various updates apacheHttpdPackages: drop mod_evasive, use recurseIntoAttrs for apacheHttpdPackages Mar 23, 2021
@aanderse aanderse mentioned this pull request Mar 23, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit fa69c57 into NixOS:master Mar 25, 2021
@aanderse aanderse deleted the apacheHttpdPackages branch March 25, 2021 11:14
@aanderse
Copy link
Member Author

Thanks @SuperSandro2000 ✨

@aanderse aanderse mentioned this pull request Jan 26, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanderse @r-rmcgibbo @SuperSandro2000 @risicle @roberth