Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procs: add libiconv to fix build #117274

Closed
wants to merge 1 commit into from
Closed

procs: add libiconv to fix build #117274

wants to merge 1 commit into from

Conversation

wildsebastian
Copy link
Contributor

@wildsebastian wildsebastian commented Mar 22, 2021 •
edited

Motivation for this change

Build fails with the error message "ld: library not found for -liconv".
I am using macOS so I am not sure if it is only an issue on macOS.
If it is only a problem on macOS, I can update the PR and add the library for macOS only.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from dalance and Br1ght0ne March 22, 2021 20:44
@SuperSandro2000
Copy link
Member

Build fails with the error message "ld: library not found for -liconv".
I am using macOS so I am not sure if it is only an issue on macOS.
If it is only a problem on macOS, I can update the PR and add the library for macOS only.

The library is only explicitly required on darwin.

@wildsebastian
procs: add libiconv to fix build
15347ac 
Build fails with the error message "ld: library not found for -liconv".
@wildsebastian
Copy link
Contributor Author

Fixed by #117559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@dalance dalance Awaiting requested review from dalance

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wildsebastian @SuperSandro2000