Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeowners: add sternenseemann for haskell #117281

Merged
merged 1 commit into from Mar 23, 2021
Merged

codeowners: add sternenseemann for haskell #117281

merged 1 commit into from Mar 23, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Mar 22, 2021 •
edited

I want to get notified about haskell PRs.

cc fyi @cdepillabout

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
codeowners: add sternenseemann for haskell
15af118 
I want to get notified about haskell PRs.
cdepillabout
cdepillabout approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this!

You should hopefully be able to merge in yourself now as well. (Although feel free to ping me one more time if it is not working for some reason!)

@sternenseemann sternenseemann merged commit f0f79f7 into NixOS:master Mar 23, 2021
@sternenseemann sternenseemann deleted the haskell-codeowners branch March 23, 2021 01:05
@sternenseemann sternenseemann restored the haskell-codeowners branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@cdepillabout cdepillabout cdepillabout approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @cdepillabout @SuperSandro2000