Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: add tests #117285

Closed
wants to merge 2 commits into from
Closed

vimPlugins: add tests #117285

wants to merge 2 commits into from

Conversation

teto
Copy link
Member

@teto teto commented Mar 22, 2021

some vim plugins need overrides to be functional. These overrides can get outdated so it makes sense to test those plugins.

We should add some code to check if those plugin commands work fine. I've tried here with minimap.vim but seems like it requires neovim 0.5 (or fails with older one).

Targeted plugins:

  • unicode-vim (we patch the path towards unicode data)
  • minimap.vim for example (we patch the path to code-minimap.vim
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

export HOME=$TMPDIR
echo $HOME
set -x
${neovim}/bin/nvim -n -u NONE -i NONE -V1 -E --cmd "set rtp+=$out/share/vim-plugins/minimap-vim" --cmd "set loadplugins" -c "MinimapToggle" +quit!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using neovim to test?

@stale
Copy link

stale bot commented Apr 17, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 17, 2022
@teto teto closed this Apr 30, 2022
@teto teto deleted the vimInfra-addTests branch April 30, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants