Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.unite: 45 -> 47 #117292

Merged
merged 1 commit into from Mar 25, 2021
Merged

gnomeExtensions.unite: 45 -> 47 #117292

merged 1 commit into from Mar 25, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add support for GOME version 40. #117081

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 22, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117292 at bb5bfd42 run on x86_64-linux 1

1 package built successfully:
  • gnomeExtensions.unite
1 suggestion:
  • warning: unused-argument

    Unused argument: coreutils.
    Near pkgs/desktops/gnome-3/extensions/unite/default.nix:1:54:

      |
1 | { lib, stdenv, gnome3, fetchFromGitHub, xprop, glib, coreutils }:
  |                                                      ^

@SuperSandro2000 SuperSandro2000 added this to In progress in GNOME 40 via automation Mar 23, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Mar 24, 2021 •
edited

Looks like there has been a new release again.

@rhoriguchi rhoriguchi changed the title gnomeExtensions.unite: 45 -> 46 gnomeExtensions.unite: 45 -> 47 Mar 24, 2021
@rhoriguchi
Copy link
Contributor Author

Looks like there has been a new release again.

done

@jtojnar jtojnar merged commit 9031057 into NixOS:master Mar 25, 2021
GNOME 40 automation moved this from In progress to Done Mar 25, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Mar 25, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
GNOME 40
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhoriguchi @r-rmcgibbo @jtojnar