Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.redhat.java: mark as broken, not available #117331

Merged
merged 1 commit into from Mar 23, 2021
Merged

vscode-extensions.redhat.java: mark as broken, not available #117331

merged 1 commit into from Mar 23, 2021

Conversation

sternenseemann
Copy link
Member

Is available for jdk >= 11 and broken for jdk < 11.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
vscode-extensions.redhat.java: mark as broken, not available
cb8951a 
Is available for jdk >= 11 and broken for jdk < 11.
collares
collares approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@collares collares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sternenseemann sternenseemann merged commit 80cef44 into NixOS:master Mar 23, 2021
@sternenseemann sternenseemann deleted the fix-versionatleast-redhat-java-fix branch March 23, 2021 12:24
@sternenseemann sternenseemann restored the fix-versionatleast-redhat-java-fix branch July 24, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collares collares collares approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @collares