Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2021.Q1.5 -> 2020.Q1.6 #117334

Merged
merged 1 commit into from Mar 24, 2021
Merged

amdvlk: 2021.Q1.5 -> 2020.Q1.6 #117334

merged 1 commit into from Mar 24, 2021

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Mar 23, 2021

Motivation for this change

2020.Q1.6 was published: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2021.Q1.6

Things done
  • Tested vkcube and Dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danieldk March 23, 2021 10:00
danieldk
danieldk approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danieldk danieldk merged commit bd76b9d into NixOS:master Mar 24, 2021
@Flakebi Flakebi deleted the amdvlk branch March 24, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @danieldk @SuperSandro2000