Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.hop-nvim: init at 2021-03-18 #117358

Closed
wants to merge 2 commits into from
Closed

vimPlugins.hop-nvim: init at 2021-03-18 #117358

wants to merge 2 commits into from

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Mar 23, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested a review from jonringer as a code owner March 23, 2021 14:25
@figsoda figsoda changed the title Hop nvim vimPlugins.hop-nvim: init at 2021-03-18 Mar 23, 2021
SuperSandro2000
SuperSandro2000 reviewed Mar 23, 2021
View reviewed changes
pkgs/misc/vim-plugins/vim-plugin-names
@@ -460,6 +460,7 @@ peitalin/vim-jsx-typescript
peterbjorgensen/sved
peterhoeg/vim-qml
phaazon/hop.nvim
phaazon/hop.nvim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin already is in nix the line above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I should have checked here instead of searching on search.nixos.org

@SuperSandro2000 SuperSandro2000 marked this pull request as draft March 23, 2021 14:27
@figsoda figsoda closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@figsoda @SuperSandro2000