Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tz: init at 0.4 #117383

Merged
merged 1 commit into from Mar 24, 2021
Merged

tz: init at 0.4 #117383

merged 1 commit into from Mar 24, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Mar 23, 2021 •
edited

Motivation for this change

Add tz: a time zone helper

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Mar 23, 2021

Result of nixpkgs-review pr 117383 run on x86_64-darwin 1

1 package built:
  • tz

@ofborg ofborg bot requested a review from kalbasit March 23, 2021 17:28
fogti
fogti reviewed Mar 23, 2021
View reviewed changes
pkgs/tools/misc/tz/default.nix
owner = "oz";
repo = "tz";
rev = "v${version}";
sha256 = "sha256-36nTau7xjABdeUOioHar28cuawFWW3DBaDH0YAvdufI=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-36nTau7xjABdeUOioHar28cuawFWW3DBaDH0YAvdufI=";
sha256 = "36nTau7xjABdeUOioHar28cuawFWW3DBaDH0YAvdufI=";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are equivalent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

catern
catern approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@catern catern left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works fine for me on NixOS.

fogti
fogti approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@fogti fogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work using Nix on Gentoo.
just the fixup phase prints a warning, but I guess it can be ignored and might be expected for go executables:

running tests
=== RUN   TestSetupZone
--- PASS: TestSetupZone (0.00s)
=== RUN   TestSetupZoneWithCustomNames
--- PASS: TestSetupZoneWithCustomNames (0.00s)
=== RUN   TestUpdateIncHour
--- PASS: TestUpdateIncHour (0.00s)
=== RUN   TestUpdateDecHour
--- PASS: TestUpdateDecHour (0.00s)
=== RUN   TestUpdateQuitMsg
--- PASS: TestUpdateQuitMsg (0.00s)
PASS
ok      github.com/oz/tz        0.003s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4
shrinking /nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4/bin/tz
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
strip is /nix/store/xdii8qvch5h8chyp0z2is2qzky565w68-binutils-2.35.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4/bin 
patching script interpreter paths in /nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4
checking for references to /build/ in /nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
/nix/store/isqh0qll1359zqsjq06bky1gflqq9dg1-tz-0.4

@siraben
Copy link
Member Author

siraben commented Mar 24, 2021 •
edited

@zseri yeah, I think because Rust Go statically links a lot by default

@fogti
Copy link
Contributor

fogti commented Mar 24, 2021

@siraben s/Rust/Go/

@SuperSandro2000 SuperSandro2000 merged commit b3e20ea into NixOS:master Mar 24, 2021
@siraben siraben deleted the tz-init branch March 25, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti fogti approved these changes

@catern catern catern approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @fogti @catern @SuperSandro2000