Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppxlib: 0.15.0 → 0.22.0 #117399

Merged
merged 2 commits into from Mar 25, 2021
Merged

ocamlPackages.ppxlib: 0.15.0 → 0.22.0 #117399

merged 2 commits into from Mar 25, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 23, 2021

Motivation for this change

Support for OCaml 4.12

cc @sternenseemann

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from puffnfresh and marsam March 23, 2021 20:00
@sternenseemann
Copy link
Member

Very cool!

This change seems to unbreak everything in 4.12 except for the stuff broken by js_of_ocaml and ocaml-ng.ocamlPackages_4_12.accessor_core which is still failing.

In ocamlPackages, nothing breaks due to this.

sternenseemann
sternenseemann reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Did test 4.10 and 4.12.

pkgs/development/ocaml-modules/ppx_import/default.nix Outdated Show resolved Hide resolved
@sternenseemann sternenseemann mentioned this pull request Mar 24, 2021
Closed
10 tasks
@vbgl
ocamlPackages.ppxlib: disable versions 0.15 and 0.18 for OCaml ≥ 4.12
e681cf9
@vbgl
ocamlPackages.ppxlib: default to 0.22.0
5bf49e9 
ocamlPackages.base_quickcheck 0.14.0 → 0.14.1

ocamlPackages.ppx_custom_printf: 0.14.0 → 0.14.1

ocamlPackages.ppx_expect: 0.14.0 → 0.14.1

ocamlPackages.ppx_optcomp: 0.14.0 → 0.14.1

ocamlPackages.ppx_sexp_conv: 0.14.1 → 0.14.3

ocamlPackages.ppx_sexp_message: 0.14.1 → 0.14.2

ocamlPackages.ppx_typerep_conv: 0.14.1 → 0.14.2

ocamlPackages.visitors: 20210127 → 20210316

ocamlPackages.pgocaml: 4.2.2 → 4.2.2-dev-20210111
@vbgl vbgl merged commit 92a1b57 into NixOS:master Mar 25, 2021
@vbgl vbgl deleted the ocaml-ppxlib-0.22.0 branch March 25, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann