Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knockpy: init at 5.0.0 #117406

Merged
merged 1 commit into from Apr 1, 2021
Merged

knockpy: init at 5.0.0 #117406

merged 1 commit into from Apr 1, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 23, 2021

Motivation for this change

Tool to scan subdomains

https://github.com/guelfoweb/knock

Related to #81418

guelfoweb/knock#95 was merged but there is no new release yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Mar 23, 2021

Result of nixpkgs-review pr 117406 run on x86_64-linux 1

1 package built:
  • knockpy

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, WFM linux x86_64 & macos 10.14

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/security/knockpy/default.nix Outdated Show resolved Hide resolved
@fabaff
Copy link
Member Author

fabaff commented Mar 29, 2021

Result of nixpkgs-review pr 117406 run on x86_64-linux 1

1 package built:
  • knockpy

@dotlambda
Copy link
Member

I find this very confusing:

Do you know how the two are related?

@fabaff
Copy link
Member Author

fabaff commented Apr 1, 2021

Do you know how the two are related?

As far as I can tell they are not.

@dotlambda dotlambda merged commit e3645c0 into NixOS:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants