Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.{language-ecmascript,fay}: unbreak #117415

Merged
merged 2 commits into from Mar 24, 2021
Merged

haskellPackages.{language-ecmascript,fay}: unbreak #117415

merged 2 commits into from Mar 24, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
haskellPackages.language-ecmascript: unbreak
624c570
@sternenseemann
haskellPackages.fay: unbreak
928d4b0 
Also unmark some obvious candidates as unbroken after testing that they
build.
cdepillabout
cdepillabout approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything marked unbroken here compiles.

@sternenseemann sternenseemann merged commit 529ba0b into NixOS:haskell-updates Mar 24, 2021
@sternenseemann sternenseemann deleted the language-ecmascript-fix branch March 24, 2021 11:20
@sternenseemann sternenseemann restored the language-ecmascript-fix branch July 24, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @cdepillabout