Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepspeech: init at 0.9.3 #117416

Merged
merged 1 commit into from Apr 11, 2021
Merged

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Closes #98770

Since this does not build from source, but rather just uses patched versions of binaries, shall -bin prefix be added here?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 23, 2021

Result of nixpkgs-review pr 117416 at 0f961737 run on x86_64-linux 1

1 package built successfully:
  • deepspeech
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/misc/deepspeech/default.nix:21:3:

       |
    21 |   installPhase = ''
       |   ^
    
  • warning: no-uri-literals

    URI literals are deprecated.
    Near pkgs/misc/deepspeech/default.nix:28:16:

       |
    28 |     homepage = https://github.com/mozilla/DeepSpeech;
       |                ^
    

Result of nixpkgs-review pr 117416 at 0f961737 run on aarch64-linux 1

1 package built successfully:
  • deepspeech
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/misc/deepspeech/default.nix:21:3:

       |
    21 |   installPhase = ''
       |   ^
    
  • warning: no-uri-literals

    URI literals are deprecated.
    Near pkgs/misc/deepspeech/default.nix:28:16:

       |
    28 |     homepage = https://github.com/mozilla/DeepSpeech;
       |                ^
    

pkgs/misc/deepspeech/default.nix Outdated Show resolved Hide resolved
pkgs/misc/deepspeech/default.nix Outdated Show resolved Hide resolved
pkgs/misc/deepspeech/default.nix Show resolved Hide resolved
pkgs/misc/deepspeech/default.nix Show resolved Hide resolved
pkgs/misc/deepspeech/default.nix Outdated Show resolved Hide resolved
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build deepspeech

@hjones2199
Copy link
Member

Result of nixpkgs-review pr 117416 run on x86_64-linux 1

1 package built:
  • deepspeech

@rvolosatovs rvolosatovs mentioned this pull request Mar 28, 2021
@rvolosatovs
Copy link
Member Author

@SuperSandro2000

@SuperSandro2000 SuperSandro2000 merged commit 75c5bce into NixOS:master Apr 11, 2021
@rvolosatovs rvolosatovs deleted the init/deepspeech branch September 6, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deepspeech
5 participants