llvmPackages: Organize files #117433
Merged
llvmPackages: Organize files #117433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase staging |
Always do pkg/default.nix not pkg.nix; use directories to avoid prefixing patches and other files.
Ericson2314
force-pushed
the
organize-llvm
branch
from
94f234c
to
19a9749
Compare
10 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Apr 15, 2021
Restructure pkgs/development/compilers/llvm/12 in a similar spirit as NixOS#117433 to mirror the other llvm directories.
10 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Apr 15, 2021
This patches are included from libcxx and libcxxabi when stdenv.hostPlatform.isMusl. After NixOS#117433 the patchs to that patch wasn't adjusted for the new structure, likely because it doesn't come up during normal eval. This fixes (among other attribute paths): * pkgsMusl.llvmPackages_12.libcxxabi * pkgsMusl.llvmPackages_12.libcxx * pkgsMusl.llvmPackages_11.libcxxabi * pkgsMusl.llvmPackages_11.libcxx * pkgsMusl.llvmPackages_10.libcxxabi * pkgsMusl.llvmPackages_10.libcxx * pkgsMusl.llvmPackages_9.libcxxabi * pkgsMusl.llvmPackages_9.libcxx * pkgsMusl.llvmPackages_8.libcxxabi * pkgsMusl.llvmPackages_8.libcxx * pkgsMusl.llvmPackages_7.libcxxabi * pkgsMusl.llvmPackages_7.libcxx * pkgsMusl.llvmPackages_6.libcxxabi * pkgsMusl.llvmPackages_6.libcxx * pkgsMusl.llvmPackages_5.libcxxabi * pkgsMusl.llvmPackages_5.libcxx Only evaluation was tested, not compilation though.
sternenseemann
added a commit
that referenced
this pull request
Apr 15, 2021
This patches are included from libcxx and libcxxabi when stdenv.hostPlatform.isMusl. After #117433 the patchs to that patch wasn't adjusted for the new structure, likely because it doesn't come up during normal eval. This fixes (among other attribute paths): * pkgsMusl.llvmPackages_12.libcxxabi * pkgsMusl.llvmPackages_12.libcxx * pkgsMusl.llvmPackages_11.libcxxabi * pkgsMusl.llvmPackages_11.libcxx * pkgsMusl.llvmPackages_10.libcxxabi * pkgsMusl.llvmPackages_10.libcxx * pkgsMusl.llvmPackages_9.libcxxabi * pkgsMusl.llvmPackages_9.libcxx * pkgsMusl.llvmPackages_8.libcxxabi * pkgsMusl.llvmPackages_8.libcxx * pkgsMusl.llvmPackages_7.libcxxabi * pkgsMusl.llvmPackages_7.libcxx * pkgsMusl.llvmPackages_6.libcxxabi * pkgsMusl.llvmPackages_6.libcxx * pkgsMusl.llvmPackages_5.libcxxabi * pkgsMusl.llvmPackages_5.libcxx Only evaluation was tested, not compilation though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Always do pkg/default.nix not pkg.nix; use directories to avoid
prefixing patches and other files.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)