Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.json-directory: mark not broken #117440

Merged
merged 1 commit into from Mar 24, 2021
Merged

haskellPackages.json-directory: mark not broken #117440

merged 1 commit into from Mar 24, 2021

Conversation

luke-clifton
Copy link
Contributor

@luke-clifton luke-clifton commented Mar 24, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • [x ] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

/rebase haskell-updates

@github-actions github-actions bot changed the base branch from master to haskell-updates March 24, 2021 07:08
@github-actions github-actions bot closed this Mar 24, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@cdepillabout cdepillabout reopened this Mar 24, 2021
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.json-directory

@cdepillabout
Copy link
Member

Looks like this builds, thanks!

@luke-clifton We normally send haskell-related PRs to the haskell-updates branch, so I used our github action to rebase this PR.

@cdepillabout cdepillabout merged commit 2bbfd8e into NixOS:haskell-updates Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luke-clifton @cdepillabout