Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio-client: 2021-03-12T03-36-59Z -> 2021-03-23T05-46-11Z #117489

Merged
merged 1 commit into from Mar 24, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/minio/mc/releases.

meta.description for minio-client is: "A replacement for ls, cp, mkdir, diff and rsync commands for filesystems and object storage"

meta.homepage for minio-client is: "https://github.com/minio/mc"

meta.changelog for minio-client is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z/bin/mc passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 2021-03-23T05-46-11Z with grep in /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z

  • found 2021-03-23T05-46-11Z in filename of file in /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z

  • directory tree listing: https://gist.github.com/e8e686042b86f5a27421f432d23beabc

  • du listing: https://gist.github.com/6bdc6576896e4fb73748904065bd3f36


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
minio-client
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A minio-client https://github.com/r-ryantm/nixpkgs/archive/1cb4599c1c4dc939eaf710d8d003f896c97d2892.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z
ls -la /nix/store/libh401hnssa3fjf864fz0byxxhdz0kx-minio-client-2021-03-23T05-46-11Z/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • minio-client

Maintainer pings

cc @edolstra @bachp @kalbasit for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 24, 2021

Result of nixpkgs-review pr 117489 at 1cb4599 run on aarch64-linux 1

1 package built successfully:
  • minio-client
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/tools/networking/minio-client/default.nix:20:3:

       |
    20 |   patchPhase = ''
       |   ^
    

Result of nixpkgs-review pr 117489 at 1cb4599 run on x86_64-linux 1

1 package built successfully:
  • minio-client
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/tools/networking/minio-client/default.nix:20:3:

       |
    20 |   patchPhase = ''
       |   ^
    

Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Successfulley ran nixos/tests/minio.nix

@bachp bachp merged commit 8004df3 into NixOS:master Mar 24, 2021
@r-ryantm r-ryantm deleted the auto-update/minio-client branch March 24, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants