Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2021.03.14 -> 2021.03.25 #117515

Merged
merged 1 commit into from Mar 24, 2021
Merged

youtube-dl: 2021.03.14 -> 2021.03.25 #117515

merged 1 commit into from Mar 24, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 24, 2021

https://github.com/ytdl-org/youtube-dl/releases/tag/2021.03.25

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 24, 2021

Result of nixpkgs-review pr 117515 at 2226668 run on aarch64-linux 1

1 package skipped due to time constraints:
  • plex-mpv-shim
31 packages built successfully:
  • botamusique
  • catt
  • celluloid
  • curseradio
  • haskellPackages.cut-the-crap
  • hydrus
  • jellyfin-mpv-shim
  • jftui
  • kodi-cli
  • lollypop
  • minitube
  • mkchromecast
  • mopidy-youtube
  • mpc-qt
  • mps-youtube
  • persepolis
  • python38Packages.mpv
  • python38Packages.pafy
  • python38Packages.tubeup
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • python39Packages.mpv
  • python39Packages.pafy
  • python39Packages.tubeup
  • python39Packages.youtube-dl
  • python39Packages.youtube-dl-light
  • qimgv
  • somafm-cli
  • sublime-music
  • tartube
  • ytcc
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/tools/misc/youtube-dl/default.nix:57:0:

       |
    57 |     description = "Command-line tool to download videos from YouTube.com and other sites";
       | ^
    

Result of nixpkgs-review pr 117515 at 2226668 run on x86_64-linux 1

2 packages skipped due to time constraints:
  • plex-media-player
  • plex-mpv-shim
33 packages built successfully:
  • botamusique
  • catt
  • celluloid
  • curseradio
  • haskellPackages.cut-the-crap
  • hydrus
  • jellyfin-mpv-shim
  • jftui
  • kodi-cli
  • lollypop
  • minitube
  • mkchromecast
  • mopidy-youtube
  • mpc-qt
  • mps-youtube
  • mpv
  • persepolis
  • python38Packages.mpv
  • python38Packages.pafy
  • python38Packages.tubeup
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • python39Packages.mpv
  • python39Packages.pafy
  • python39Packages.tubeup
  • python39Packages.youtube-dl
  • python39Packages.youtube-dl-light
  • qimgv
  • somafm-cli
  • sublime-music
  • tartube
  • ytcc
  • ytfzf
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/tools/misc/youtube-dl/default.nix:57:0:

       |
    57 |     description = "Command-line tool to download videos from YouTube.com and other sites";
       | ^
    

@zowoq zowoq merged commit 6aa079e into NixOS:master Mar 24, 2021
@zowoq
Copy link
Contributor Author

zowoq commented Mar 24, 2021

20.09: cf439cc

@zowoq zowoq deleted the ytdl branch March 24, 2021 21:15
@zowoq zowoq added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants