Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zziplib: fix missing links on darwin #117526

Merged
merged 1 commit into from Mar 25, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 24, 2021

Motivation for this change

Closes: #117485

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 24, 2021
@ofborg ofborg bot requested a review from AndersonTorres March 24, 2021 22:06
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 24, 2021

Result of nixpkgs-review pr 117526 at ecc9070 run on aarch64-linux 1

10 packages marked as broken and skipped:
  • asymptote
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • herwig
  • polymake
  • python38Packages.cnvkit
  • python39Packages.cnvkit
  • spark
  • spring
  • springLobby
100 packages skipped due to time constraints:
  • R
  • adapta-gtk-theme
  • alephone
  • apostrophe
  • asciidoc-full
  • asciidoc-full-with-plugins
  • auctex
  • autofs5
  • btrbk
  • ccache
  • ...
10 packages built successfully:
  • desmume
  • evince (gnome3.evince)
  • gummi
  • lua51Packages.luazip
  • luaPackages.luazip (lua52Packages.luazip)
  • lua53Packages.luazip
  • luajitPackages.luazip
  • mate.atril
  • texlive.combined.scheme-infraonly
  • zziplib

Result of nixpkgs-review pr 117526 at ecc9070 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • spark
  • spring
  • springLobby
121 packages skipped due to time constraints:
  • R
  • adapta-gtk-theme
  • apostrophe
  • asciidoc-full
  • asciidoc-full-with-plugins
  • asymptote
  • auctex
  • autofs5
  • btrbk
  • ccache
  • ...
20 packages built successfully:
  • alephone
  • alephone-durandal
  • alephone-eternal
  • alephone-evil
  • alephone-infinity
  • alephone-marathon
  • alephone-pathways-into-darkness
  • alephone-pheonix
  • alephone-red
  • alephone-rubicon-x
  • evince (gnome3.evince)
  • gummi
  • lua51Packages.luazip
  • luaPackages.luazip (lua52Packages.luazip)
  • lua53Packages.luazip
  • luajitPackages.luazip
  • mate.atril
  • milkytracker
  • texlive.combined.scheme-infraonly
  • zziplib

@AndersonTorres
Copy link
Member

Ofborg is hanging on Darwin.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 25, 2021

I build it manually on darwin and it caused about 3000 depended packages to rebuild but zziplib builds.

@SuperSandro2000 SuperSandro2000 merged commit 77cf1c3 into NixOS:master Mar 25, 2021
@veprbl veprbl deleted the pr/zziplib_darwin_fix branch March 25, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zziplib: -lzzip doesn't work on darwin
5 participants