Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-my-fish: init at 7+unstable=2021-03-03 #117532

Merged
merged 1 commit into from Aug 9, 2021
Merged

oh-my-fish: init at 7+unstable=2021-03-03 #117532

merged 1 commit into from Aug 9, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 24, 2021 •
edited

Motivation for this change

Closes #68886

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres marked this pull request as draft March 24, 2021 22:50
@AndersonTorres AndersonTorres changed the title [wip] oh-my-fish: init at unstable-2021-03-03 [wip] oh-my-fish: init at 7+unstable-2021-03-03 Aug 9, 2021
@AndersonTorres AndersonTorres marked this pull request as ready for review August 9, 2021 14:58
@AndersonTorres AndersonTorres changed the title [wip] oh-my-fish: init at 7+unstable-2021-03-03 oh-my-fish: init at 7+unstable-2021-03-03 Aug 9, 2021
@AndersonTorres AndersonTorres merged commit 73e770e into NixOS:master Aug 9, 2021
@AndersonTorres AndersonTorres changed the title oh-my-fish: init at 7+unstable-2021-03-03 oh-my-fish: init at 7+unstable=2021-03-03 Aug 9, 2021
@AndersonTorres AndersonTorres deleted the new-oh-my-fish branch September 29, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oh My Fish for Fish shell
2 participants
@AndersonTorres @SuperSandro2000