Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 40 fixups #117535

Merged
merged 5 commits into from Mar 25, 2021
Merged

GNOME 40 fixups #117535

merged 5 commits into from Mar 25, 2021

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Mar 24, 2021

Motivation for this change

For #117081

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 25, 2021

Result of nixpkgs-review pr 117535 at a275df65 run on aarch64-linux 1

3 packages skipped due to time constraints:
  • gnome3.gnome-calendar
  • gnome3.gnome-session (gnome3.gnome_session)
  • pantheon.elementary-session-settings
2 packages built successfully:
  • cantarell-fonts
  • orca (gnome3.orca)
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/data/fonts/cantarell-fonts/default.nix:34:5:

       |
    34 |     maintainers = with lib.maintainers; [ ];
       |     ^
    

Result of nixpkgs-review pr 117535 at a275df65 run on x86_64-linux 1

5 packages built successfully:
  • cantarell-fonts
  • gnome3.gnome-calendar
  • gnome3.gnome-session (gnome3.gnome_session)
  • orca (gnome3.orca)
  • pantheon.elementary-session-settings
5 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/data/fonts/cantarell-fonts/default.nix:34:5:

       |
    34 |     maintainers = with lib.maintainers; [ ];
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/desktops/gnome-3/core/gnome-session/default.nix:18:5:

       |
    18 |     (substituteAll {
       |     ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/desktops/gnome-3/apps/gnome-calendar/default.nix:82:5:

       |
    82 |     license = licenses.gpl3;
       |     ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/desktops/gnome-3/apps/gnome-calendar/default.nix:3:3:

      |
    3 | , fetchpatch
      |   ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/desktops/gnome-3/core/gnome-session/default.nix:4:3:

      |
    4 | , fetchpatch }:
      |   ^
    

@amaxine amaxine force-pushed the maxine/gnome-40-session-fixup branch from a275df6 to 8c9e14f Compare March 25, 2021 00:35
@jtojnar jtojnar merged commit 3920d38 into NixOS:gnome-40 Mar 25, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Mar 25, 2021

Thanks.

@amaxine amaxine deleted the maxine/gnome-40-session-fixup branch July 19, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants