zabbix.agent2: init at 5.0.5

[aanderse]

Motivation for this change

There is a drop in replacement for zabbix.agent: zabbix.agent2. While zabbix.agent was written in c, zabbix.agent2 is mostly written in go with a bit of c glue.

A massive thank you to @tomberek who packaged this with me. I was really lost on how to package this and he led me through the whole process. What a champion! 🚀

I ran a full set of tests on this today on a server that was running zabbix.agent, so testing was thorough 👍

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[aanderse]

Thanks again @tomberek 🎉

[zowoq]

Just setting modRoot = "src/go" instead of overrideModAttrs should work.

[aanderse]

Unfortunately not because source code outside of this directory is needed.

[zowoq]

This seems to work?

diff --git a/pkgs/servers/monitoring/zabbix/agent2.nix b/pkgs/servers/monitoring/zabbix/agent2.nix
index f3c1be0f8e2..5f77528f48b 100644
--- a/pkgs/servers/monitoring/zabbix/agent2.nix
+++ b/pkgs/servers/monitoring/zabbix/agent2.nix
@@ -40,7 +40,7 @@ import ./versions.nix ({ version, sha256 }:
     # we need to manipulate a number of things for their build
     # system to properly work
     buildPhase = ''
-      cp -r vendor src/go/vendor
+      cd ../..
       make
     '';
 
@@ -49,12 +49,7 @@ import ./versions.nix ({ version, sha256 }:
       install -Dm0755 src/go/bin/zabbix_agent2 $out/bin/zabbix_agent2
     '';
 
-    # run `go mod vendor` from the correct directory
-    overrideModAttrs = (_oldAttrs : {
-      preConfigure = ''
-        cd src/go
-        '';
-    });
+    modRoot = "src/go";
 
     meta = with lib; {
       description = "An enterprise-class open source distributed monitoring solution (client-side agent)";

[aanderse]

That's great! Thanks for taking a look. Would you be willing to make a PR? I can test.

[SuperSandro2000]

Suggested change

	nativeBuildInputs = [ autoreconfHook pkg-config];
	nativeBuildInputs = [ autoreconfHook pkg-config ];