Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: be explicit on whether it is python2 or python3 that is used #117570

Merged
merged 72 commits into from Mar 25, 2021
Merged

Python: be explicit on whether it is python2 or python3 that is used #117570

merged 72 commits into from Mar 25, 2021

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Mar 25, 2021 •
edited

Motivation for this change

#101964 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from Profpatsch as a code owner March 25, 2021 09:48
@FRidh FRidh changed the title Python: introduce alias for python WIP: Python: introduce alias for python Mar 25, 2021
@FRidh FRidh marked this pull request as draft March 25, 2021 10:01
@FRidh FRidh mentioned this pull request Mar 25, 2021
Closed
77 tasks
@FRidh FRidh changed the title WIP: Python: introduce alias for python WIP: Python: be explicit on whether it is python2 or python3 Mar 25, 2021
@FRidh FRidh changed the title WIP: Python: be explicit on whether it is python2 or python3 Python: be explicit on whether it is python2 or python3 that is used Mar 25, 2021
@FRidh FRidh marked this pull request as ready for review March 25, 2021 12:26
@FRidh FRidh merged commit 350f9bd into NixOS:master Mar 25, 2021
@FRidh FRidh deleted the python2alias branch March 25, 2021 12:27
@FRidh
Copy link
Member Author

FRidh commented Mar 25, 2021

Plenty left I think but that's for another time.

@FRidh FRidh mentioned this pull request Jan 15, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh