Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccnet: drop #117579

Merged
merged 2 commits into from Mar 26, 2021
Merged

ccnet: drop #117579

merged 2 commits into from Mar 26, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@dotlambda please resolve the merge conflict.

@dotlambda
seafile-shared: remove unused arguments
f099477
@dotlambda
ccnet: drop
b0de354 
Its only user seafile-share does not depend on it anymore and the
upstream repository has not been updated since 2017.
@dotlambda
Copy link
Member Author

done

@SuperSandro2000 SuperSandro2000 merged commit 0708f10 into NixOS:master Mar 26, 2021
@dotlambda dotlambda deleted the ccnet-drop branch March 26, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardosm eduardosm eduardosm approved these changes

@freezeboy freezeboy Awaiting requested review from freezeboy

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @SuperSandro2000 @eduardosm