vistafonts: fix build #117604
Merged
vistafonts: fix build #117604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
32
to
34
| outputHashAlgo = "sha256"; | ||
| outputHashMode = "recursive"; | ||
| outputHash = "0cnvy7w18ga6m8sln7rzd9rbxzfx2b0ghl9m4pjzrmah5xfm5cn7"; |
There was a problem hiding this comment.
mkDerivation does not require this.
There was a problem hiding this comment.
It makes the hash depend only on the result, so it avoids unnecessary rebuilds. The package contains font files that won't change if the environment is updated. Other font packages, such as corefonts or cantarell-fonts also do this.
There was a problem hiding this comment.
How long does the package take to build? If it only takes 5 seconds than this is not worth it.
Build was previously failing with ``` /build/file: no valid cabinets found ``` Additonaly, a faster download mirror is used. The downloaded file is not identical to the one from the previous mirror, but the produced result is unchanged.
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build was previously failing with
Additonaly, a faster download mirror is used. The downloaded file is not identical to the one from the previous mirror, but the produced result is unchanged.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)