Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pykodi: init at 0.2.3 #117616

Merged
merged 2 commits into from Mar 25, 2021
Merged

pykodi: init at 0.2.3 #117616

merged 2 commits into from Mar 25, 2021

Conversation

sephalon
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117616 at b632f82 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.pykodi
  • python39Packages.pykodi
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pykodi/default.nix:17:0:

       |
17 |     description = "An async python interface for Kodi over JSON-RPC";
   | ^

jonringer
jonringer approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 117616 run on x86_64-linux 1

2 packages built:
  • python38Packages.pykodi
  • python39Packages.pykodi

@jonringer jonringer merged commit ea2c9dd into NixOS:master Mar 25, 2021
@SuperSandro2000
Copy link
Member

Does home-assistant have tests kodi? Can we enable them?

@sephalon
Copy link
Contributor Author

@SuperSandro2000 There is; see 3c88bee, but I was too late…

@sephalon sephalon deleted the pykodi branch May 14, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sephalon @r-rmcgibbo @SuperSandro2000 @jonringer