nixos/docker: re-add network.target #117618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if docker starts concurrently with firewall.service/systemd-networkd it breaks both due to iptables/netlink logs.
| @@ -157,6 +157,7 @@ in | |||
|
|
|||
| systemd.services.docker = { | |||
| wantedBy = optional cfg.enableOnBoot "multi-user.target"; | |||
| after = [ "network.target" "docker.socket" ]; | |||
There was a problem hiding this comment.
docker-ce unit:
[Unit] Description=Docker Application Container Engine
Documentation=https://docs.docker.com
After=network-online.target firewalld.service containerd.service
Wants=network-online.target
Requires=docker.socket containerd.service
There was a problem hiding this comment.
We don't have firewalld. We do have containerd.service but I currently fail to see how docker is relating to containerd. We built docker with its own containerd.
There was a problem hiding this comment.
I would only switch from network.target to network-online.target if we have very good reason to. Right now I would say it is enough to have a working firewall and systemd / scripted networking not interfering with dockers network setup.
There was a problem hiding this comment.
Docker is the glue to get the containers in containerd running.
I just posted the file for comparison.
This was referenced Mar 26, 2021
SuperSandro2000
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if docker starts concurrently with
firewall.service/systemd-networkd it breaks both due to iptables/netlink
logs.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)