Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron_12: 12.0.1 -> 12.0.2 & electron_11: 11.3.0 -> 11.4.1 & electron_10: 10.4.0 -> 10.4.2 #117621

Merged
merged 3 commits into from Mar 25, 2021

Conversation

TredwellGit
Copy link
Member

Motivation for this change

https://github.com/electron/electron/releases/tag/v12.0.2

https://github.com/electron/electron/releases/tag/v11.4.0
https://github.com/electron/electron/releases/tag/v11.4.1

https://github.com/electron/electron/releases/tag/v10.4.1
https://github.com/electron/electron/releases/tag/v10.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117621 at a4cacf2 run on x86_64-linux 1

13 packages built successfully:
  • _1password-gui
  • electron (electron_12)
  • electron_10
  • electron_11
  • element-desktop
  • freetube
  • jitsi-meet-electron
  • logseq
  • nix-tour
  • obsidian
  • teleprompter
  • todoist-electron
  • vieb

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 117621 run on x86_64-linux 1

13 packages built:
  • _1password-gui
  • electron (electron_12)
  • electron_10
  • electron_11
  • element-desktop
  • freetube
  • jitsi-meet-electron
  • logseq
  • nix-tour
  • obsidian
  • teleprompter
  • todoist-electron
  • vieb

@SuperSandro2000 SuperSandro2000 merged commit d5178d6 into NixOS:master Mar 25, 2021
@TredwellGit TredwellGit deleted the electron branch March 25, 2021 23:47
@Ma27
Copy link
Member

Ma27 commented Apr 16, 2021

Backport in #119241.

@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants