Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: fix upstream domain name #117631

Merged
merged 1 commit into from Mar 26, 2021

Conversation

wesleywright
Copy link
Contributor

@wesleywright wesleywright commented Mar 25, 2021

The VS Code team recently retired a deprecated domain used for VS Code downloads. This breaks update-vscode.sh and customized package installations (such as used by home-manager). The new domain name is the one preferred by the VS Code team, as stated in this GitHub issue: microsoft/vscode#119822

Motivation for this change

All builds of the vscode package are currently broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The VS Code team recently retired a deprecated domain used for VS Code
downloads. This breaks update-vscode.sh and customized package
installations (such as used by home-manager). The new domain name is the
one preferred by the VS Code team, as stated in this GitHub issue:
microsoft/vscode#119822
@wesleywright
Copy link
Contributor Author

I haven't tested extensively (and I'm relatively new to Nix and not sure how to use sandboxing for a one-off build with my current setup), but I should note that I didn't change any of the pinned checksums and the build completes successfully. I expect this should have 0 impact on build or runtime behavior (beyond the download succeeding instead of failing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants