Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlPackages.pg_auto_failover: 1.4.2 -> 1.5.1 #117641

Merged
merged 1 commit into from Mar 29, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 26, 2021

Motivation for this change

https://github.com/citusdata/pg_auto_failover/releases/tag/v1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 26, 2021

Result of nixpkgs-review pr 117641 at 78e624c run on x86_64-linux 1

1 package built successfully:
  • postgresqlPackages.pg_auto_failover (postgresql11Packages.pg_auto_failover)
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/sql/postgresql/ext/pg_auto_failover.nix:16:3:

       |
    16 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 117641 at 78e624c run on aarch64-linux 1

1 package built successfully:
  • postgresqlPackages.pg_auto_failover (postgresql11Packages.pg_auto_failover)
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/sql/postgresql/ext/pg_auto_failover.nix:16:3:

       |
    16 |   installPhase = ''
       |   ^
    

@marsam marsam merged commit 632ae08 into NixOS:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants