Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] thunderbird, thunderbird-bin: 78.8.1 -> 78.9.0 [High security fixes] #117644

Merged
merged 2 commits into from Mar 26, 2021
Merged

[20.09] thunderbird, thunderbird-bin: 78.8.1 -> 78.9.0 [High security fixes] #117644

merged 2 commits into from Mar 26, 2021

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 26, 2021

Motivation for this change

#117577 for 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0
thunderbird-bin: 78.8.1 -> 78.9.0
d79a090 
(cherry picked from commit 6a5bbc1)
@taku0
thunderbird: 78.8.1 -> 78.9.0
4fc3ff0 
(cherry picked from commit 8922a34)
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117644 at 4fc3ff0 run on x86_64-linux 1

1 package skipped due to time constraints:
  • thunderbird (thunderbird-78)
1 package built successfully:
  • thunderbird-bin (thunderbird-bin-78)

vcunat
vcunat approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used -bin for a while and compiled thunderbird for hours now. No problems expected.

@lovesegfault lovesegfault merged commit 2df0627 into NixOS:release-20.09 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @r-rmcgibbo @vcunat @wamserma @lovesegfault