llfuse: disable tests on Darwin #117695
Merged
llfuse: disable tests on Darwin #117695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just started nixpkgs-review, hopefully it should be able to finish in 5 hours. |
midchildan
force-pushed
the
fix/disable-llfuse-darwin-test
branch
from
17e7eb6
to
278ce95
Compare
|
Rebased to fix conflicts. |
dotlambda
requested changes
Mar 26, 2021
| propagatedBuildInputs = [ contextlib2 ]; | ||
| checkInputs = [ pytestCheckHook which ]; |
There was a problem hiding this comment.
Don't move around random stuff.
There was a problem hiding this comment.
This was the precise location of the merge conflict. I should've checked the resulting diff more closely.
dotlambda
changed the title
midchildan
force-pushed
the
fix/disable-llfuse-darwin-test
branch
from
278ce95
to
1c36a08
Compare
dotlambda
requested changes
Mar 26, 2021
| @@ -26,21 +26,18 @@ buildPythonPackage rec { | |||
| }; | |||
|
|
|||
| nativeBuildInputs = [ cython pkg-config ]; | |||
|
|
|||
Fixes NixOS#117665. The tests require macFUSE[1], an external dependency to be installed. [1]: https://osxfuse.github.io/
midchildan
force-pushed
the
fix/disable-llfuse-darwin-test
branch
from
1c36a08
to
f7c5b31
Compare
|
Result of 3 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #117665. The tests require macFUSE, an external dependency to be installed.
I last tested this package in #116958, and this PR is probably safe too as no change has been made to it since. I'm building this change on my local machine right now, but it would take a while for it to complete as the latestBuilt and tested on macOS, no rebuilds on Linux.masterseems to require a rebuild of stdenv.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)